Log evaluation history in new tables #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
commented
Jun 19, 2024
| @@ -191,7 +191,7 @@ func (e *Executor) evalEntityEvent(ctx context.Context, inf *entities.EntityInfo | |||
| // Let's evaluate all the rules for this profile | |||
| err = profiles.TraverseRules(relevant, func(rule *pb.Profile_Rule) error { | |||
| // Get the engine evaluator for this rule type | |||
| evalParams, ruleEngine, actions, err := e.getEvaluator( | |||
| evalParams, ruleEngine, actionEngine, err := e.getEvaluator( | |||
There was a problem hiding this comment.
Two small changes in this file:
- Rename
actionstoactionEngineto avoid shadowing an import name - Move
SetActionsErrdirectly under the call to run actions.
JAORMX
previously approved these changes
Jun 19, 2024
dmjb
force-pushed
the
history-service
branch
2 times, most recently
from
66b296b
to
bd354c2
Compare
This adds an interface and implementation for logging rule evaluation statuses. The logic flow is described in the design doc. Note that this does not wire in the logic into the engine yet, nor does it track remediations/alerts. These will be added in future PRs. Relates to: #3556
blkt
approved these changes
Jun 19, 2024
rdimitrov
approved these changes
Jun 19, 2024
puerco
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an interface and implementation for logging rule evaluation statuses. The logic flow is described in the design doc. Note that this does not wire in the logic into the engine yet, nor does it track remediations/alerts. These will be added in future PRs.
Relates to: #3556
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: